[FIX] Projections: Retain embedding if non-relevant variables change #3428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VesnaT
force-pushed
the
optimize_projections
branch
from
8c14d66
to
ced1ca9
Compare
Codecov Report
@@ Coverage Diff @@
## master #3428 +/- ##
==========================================
- Coverage 83.17% 83.17% -0.01%
==========================================
Files 362 362
Lines 63832 63857 +25
==========================================
+ Hits 53094 53110 +16
- Misses 10738 10747 +9 |
VesnaT
force-pushed
the
optimize_projections
branch
from
ced1ca9
to
34e0a2f
Compare
janezd
requested changes
Nov 30, 2018
| # Input | ||
| @Inputs.data | ||
| @check_sql_input | ||
| def set_data(self, data): | ||
| same_domain = (self.data and data and | ||
| data_exists = self.data is not None |
| @@ -552,8 +573,6 @@ def sizeHint(self): | |||
| return QSize(1132, 708) | |||
|
|
|||
| def clear(self): | |||
| self.data = None | |||
| self.valid_data = None | |||
There was a problem hiding this comment.
Do this in inherited check_data.
Orange/widgets/unsupervised/owmds.py
Outdated
| self.graph.set_effective_matrix(None) | ||
| self.__set_update_loop(None) | ||
| self.__state = OWMDS.Waiting | ||
|
|
||
| def _initialize(self): | ||
| matrix_exists = self.effective_matrix is not None |
Orange/widgets/unsupervised/owmds.py
Outdated
|
|
||
| def clear(self): | ||
| def clear(self, with_attr_values=True): |
There was a problem hiding this comment.
Remove flag, call init_attr_values instead
VesnaT
force-pushed
the
optimize_projections
branch
from
34e0a2f
to
b6c23c2
Compare
VesnaT
force-pushed
the
optimize_projections
branch
from
b6c23c2
to
1a519d7
Compare
janezd
approved these changes
Nov 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Embedding was recalculated and the graph reploted even though the variables used remain the same with new input data.
Description of changes
Adjust OWDataProjectionWidget not to recalculate the embedding.
Consider MDS separately since it takes two inputs (DataTable, DistMatrix).
Fix OWRadViz and OWLinearProjection not to plot data until available features list box is set.
Includes